fix!: bind wallet+payload into typehash, store signed nonce, write renewals #1

Merged

peersky merged 1 commit from fix/record-lifecycle-typehash into main

2026-09-07 08:36:04 +00:00

peersky commented

2026-09-07 05:00:33 +00:00

Owner

_TYPEHASH gains address wallet and bytes32 payload; _validateRecord
encodes them, closing register() front-run via wallet swap
renewRecord() routes through _setRecord and requires signed record to
match resolved id and wallet (idMismatch/walletMismatch errors)
_setRecord requires record.nonce > stored nonce and persists signed
value: renewal replay dead, deleteName bump effective, first
registration needs nonce >= 1
nameToId hygiene: delete old name mapping before write; skip zero
names so nameless records don't collide on nameToId[0]
Record gains bytes32 payload, stored per id, returned by resolveRecord

BREAKING CHANGE: registrar signature typehash changed; existing signing
infrastructure must re-sign with new registerName(...,address wallet,
bytes32 payload) schema and nonces starting at 1.

- _TYPEHASH gains address wallet and bytes32 payload; _validateRecord encodes them, closing register() front-run via wallet swap - renewRecord() routes through _setRecord and requires signed record to match resolved id and wallet (idMismatch/walletMismatch errors) - _setRecord requires record.nonce > stored nonce and persists signed value: renewal replay dead, deleteName bump effective, first registration needs nonce >= 1 - nameToId hygiene: delete old name mapping before write; skip zero names so nameless records don't collide on nameToId[0] - Record gains bytes32 payload, stored per id, returned by resolveRecord BREAKING CHANGE: registrar signature typehash changed; existing signing infrastructure must re-sign with new registerName(...,address wallet, bytes32 payload) schema and nonces starting at 1.

peersky added 1 commit

2026-09-07 05:00:33 +00:00

fix!: bind wallet+payload into typehash, store signed nonce, write renewals

CI / test (pull_request) Has been cancelled

Details

CI / lint (pull_request) Has been cancelled

Details

c6525fcd57

- _TYPEHASH gains address wallet and bytes32 payload; _validateRecord
  encodes them, closing register() front-run via wallet swap
- renewRecord() routes through _setRecord and requires signed record to
  match resolved id and wallet (idMismatch/walletMismatch errors)
- _setRecord requires record.nonce > stored nonce and persists signed
  value: renewal replay dead, deleteName bump effective, first
  registration needs nonce >= 1
- nameToId hygiene: delete old name mapping before write; skip zero
  names so nameless records don't collide on nameToId[0]
- Record gains bytes32 payload, stored per id, returned by resolveRecord

BREAKING CHANGE: registrar signature typehash changed; existing signing
infrastructure must re-sign with new registerName(...,address wallet,
bytes32 payload) schema and nonces starting at 1.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01T43qZEXdPmGfhqbQC8N5n7

peersky force-pushed fix/record-lifecycle-typehash from c6525fcd57

CI / test (pull_request) Has been cancelled

Details

CI / lint (pull_request) Has been cancelled

Details

to 93985f0bd8

CI / lint (pull_request) Successful in 46s

Details

CI / test (pull_request) Successful in 54s

Details

2026-09-07 05:01:28 +00:00

Compare