peeramid-labs/quorum-rs
Watch
1
0
Fork
You've already forked quorum-rs
 0
Code Issues Pull requests Projects Releases 2 Packages Wiki Activity Actions

revert(project): remove the project-advanced route #82

Merged
peersky merged 1 commit from revert/the-project-advanced-route into dev 2026-08-26 06:10:58 +00:00
Conversation 0 Commits 1 Files changed 4 +1 -438
peersky commented 2026-08-26 06:08:46 +00:00
Owner
Copy link
  • Removed Redundancy of a second signal saying the answer moved: the consensus location already tells a caller where its answer is, on the subject it already watches.
  • Removed Redundancy of a publisher with no reader: the sync loop that was its only consumer was never called, so every job published this to nobody.
  • Fixed Bug in what it was keyed on: the project id is a root-commit sha, and answer-mode repos bootstrapped in the same second share one, so the subject could carry a thread's head to an unrelated thread's holders.
- Removed Redundancy of a second signal saying the answer moved: the consensus location already tells a caller where its answer is, on the subject it already watches. - Removed Redundancy of a publisher with no reader: the sync loop that was its only consumer was never called, so every job published this to nobody. - Fixed Bug in what it was keyed on: the project id is a root-commit sha, and answer-mode repos bootstrapped in the same second share one, so the subject could carry a thread's head to an unrelated thread's holders.
revert(project): remove the project-advanced route
All checks were successful
CI / Dependency Age Check (pull_request) Successful in 4s
Details
CI / Lint & Audit (pull_request) Successful in 1m7s
Details
CI / Spell Check (pull_request) Successful in 5s
Details
Commit Lint / Validate PR Title (pull_request) Successful in 3s
Details
Publish Release / Create Tag & Sync (pull_request) Has been skipped
Details
Publish Release / Publish to crates.io (pull_request) Has been skipped
Details
Publish Release / Publish dry-run (no side effects) (pull_request) Has been skipped
Details
Publish Release / Create GitHub Release (pull_request) Has been skipped
Details
CI / Test (pull_request) Successful in 5m0s
Details
a0d13fcac0
 
- Removed Redundancy of a second signal saying the answer moved: the consensus location already tells a caller where its answer is, on the subject it already watches.
- Removed Redundancy of a publisher with no reader: the sync loop that was its only consumer was never called, so every job published this to nobody.
- Fixed Bug in what it was keyed on: the project id is a root-commit sha, and answer-mode repos bootstrapped in the same second share one, so the subject could carry a thread's head to an unrelated thread's holders.
peersky deleted branch revert/the-project-advanced-route 2026-08-26 06:10:58 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
release
Automated release PR

No labels
release
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
peeramid-labs/quorum-rs!82
No description provided.